From 6369a4d369e5a1c0f66277c415c04f2431fb1901 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:25:55 +0200 Subject: [PATCH 01/21] Fix pydoclint errors in ui/screens/operations/governance_operations/proxy/proxy.py.Proxy --- .../operations/governance_operations/proxy/proxy.py | 7 ++++++- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/clive/__private/ui/screens/operations/governance_operations/proxy/proxy.py b/clive/__private/ui/screens/operations/governance_operations/proxy/proxy.py index c12be107d6..aadf0b6c48 100644 --- a/clive/__private/ui/screens/operations/governance_operations/proxy/proxy.py +++ b/clive/__private/ui/screens/operations/governance_operations/proxy/proxy.py @@ -72,7 +72,12 @@ class ProxySet(ProxyBaseContainer): class Proxy(TabPane, CliveWidget): - """TabPane with all content about proxy.""" + """ + TabPane with all content about proxy. + + Attributes: + DEFAULT_CSS: Default CSS for the proxy tab pane. + """ DEFAULT_CSS = get_css_from_relative_path(__file__) diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 04df7ec77a..5d7bb68dc3 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -405,10 +405,6 @@ clive/__private/ui/screens/operations/governance_operations/common_governance/go DOC103: Method `GovernanceListWidget._create_row`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [data: GovernanceDataT, even: bool]. DOC201: Method `GovernanceListWidget._create_row` does not have a return section in docstring -------------------- -clive/__private/ui/screens/operations/governance_operations/proxy/proxy.py - DOC601: Class `Proxy`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `Proxy`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) --------------------- clive/__private/ui/screens/operations/governance_operations/witness/witness.py DOC101: Method `WitnessNameLabel.__init__`: Docstring contains fewer arguments than in function signature. DOC103: Method `WitnessNameLabel.__init__`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [classes: str, witness_name: str]. -- GitLab From 0e45a765534f0b1a3e3aecf17c6613f707443d6c Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:27:31 +0200 Subject: [PATCH 02/21] Fix pydoclint errors in ui/screens/operations/governance_operations/witness/witness.py.WitnessNameLabel --- .../operations/governance_operations/witness/witness.py | 8 +++++++- pydoclint-errors-baseline.txt | 2 -- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/clive/__private/ui/screens/operations/governance_operations/witness/witness.py b/clive/__private/ui/screens/operations/governance_operations/witness/witness.py index c13c3c0ab7..26e277dfae 100644 --- a/clive/__private/ui/screens/operations/governance_operations/witness/witness.py +++ b/clive/__private/ui/screens/operations/governance_operations/witness/witness.py @@ -67,7 +67,13 @@ class WitnessDetailsLabel(Label): class WitnessNameLabel(Label, CliveWidget): - """Label with witness name.""" + """ + Label with witness name. + + Args: + witness_name: Name of the witness to be displayed. + classes: Optional CSS classes for the label. + """ def __init__(self, witness_name: str, classes: str) -> None: super().__init__( diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 5d7bb68dc3..9366819fd4 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -406,8 +406,6 @@ clive/__private/ui/screens/operations/governance_operations/common_governance/go DOC201: Method `GovernanceListWidget._create_row` does not have a return section in docstring -------------------- clive/__private/ui/screens/operations/governance_operations/witness/witness.py - DOC101: Method `WitnessNameLabel.__init__`: Docstring contains fewer arguments than in function signature. - DOC103: Method `WitnessNameLabel.__init__`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [classes: str, witness_name: str]. DOC601: Class `Witness`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `Witness`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [BINDINGS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC601: Class `Search`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab From fec2046a061696a96f2311c34de7cb420d546979 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:34:11 +0200 Subject: [PATCH 03/21] Fix pydoclint errors in ui/screens/operations/governance_operations/witness/witness.py.WitnessManualSearch.Search --- .../governance_operations/witness/witness.py | 15 +++++++++++++-- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/clive/__private/ui/screens/operations/governance_operations/witness/witness.py b/clive/__private/ui/screens/operations/governance_operations/witness/witness.py index 26e277dfae..602bbd1748 100644 --- a/clive/__private/ui/screens/operations/governance_operations/witness/witness.py +++ b/clive/__private/ui/screens/operations/governance_operations/witness/witness.py @@ -84,7 +84,12 @@ class WitnessNameLabel(Label, CliveWidget): class Witness(GovernanceTableRow[WitnessData]): - """Check if there is a witness in the action table - if so, move True to the WitnessCheckbox parameter.""" + """ + Check if there is a witness in the action table - if so, move True to the witness checkbox parameter. + + Attributes: + BINDINGS: List of predefined bindings for the witness row. + """ BINDINGS = [CLIVE_PREDEFINED_BINDINGS.operations.witness_show_details.create(description="Details")] @@ -128,7 +133,13 @@ class WitnessManualSearch(Grid): @dataclass class Search(Message): - """Emitted when the search button is pressed.""" + """ + Emitted when the search button is pressed. + + Attributes: + pattern: The pattern to search for in witness names. + limit: The maximum number of witnesses to return. + """ pattern: str limit: int diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 9366819fd4..8c14c24d3e 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -406,10 +406,6 @@ clive/__private/ui/screens/operations/governance_operations/common_governance/go DOC201: Method `GovernanceListWidget._create_row` does not have a return section in docstring -------------------- clive/__private/ui/screens/operations/governance_operations/witness/witness.py - DOC601: Class `Witness`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `Witness`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [BINDINGS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC601: Class `Search`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `Search`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [limit: int, pattern: str]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC601: Class `Witnesses`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `Witnesses`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC101: Method `Witnesses._create_operation`: Docstring contains fewer arguments than in function signature. -- GitLab From 62da03e24fe31704cba7648af58778c48ec45ce6 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:34:52 +0200 Subject: [PATCH 04/21] Fix pydoclint errors in ui/screens/operations/governance_operations/witness/witness.py.Witnesses --- .../operations/governance_operations/witness/witness.py | 7 ++++++- pydoclint-errors-baseline.txt | 2 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/clive/__private/ui/screens/operations/governance_operations/witness/witness.py b/clive/__private/ui/screens/operations/governance_operations/witness/witness.py index 602bbd1748..5945e9536f 100644 --- a/clive/__private/ui/screens/operations/governance_operations/witness/witness.py +++ b/clive/__private/ui/screens/operations/governance_operations/witness/witness.py @@ -268,7 +268,12 @@ class WitnessesTable(GovernanceTable[WitnessData, WitnessesDataProvider]): class Witnesses(GovernanceTabPane): - """TabPane with all content about witnesses.""" + """ + TabPane with all content about witnesses. + + Attributes: + DEFAULT_CSS: Default CSS for the witnesses tab pane. + """ DEFAULT_CSS = get_css_from_relative_path(__file__) diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 8c14c24d3e..5237f400e9 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -406,8 +406,6 @@ clive/__private/ui/screens/operations/governance_operations/common_governance/go DOC201: Method `GovernanceListWidget._create_row` does not have a return section in docstring -------------------- clive/__private/ui/screens/operations/governance_operations/witness/witness.py - DOC601: Class `Witnesses`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `Witnesses`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC101: Method `Witnesses._create_operation`: Docstring contains fewer arguments than in function signature. DOC103: Method `Witnesses._create_operation`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [vote: bool, witness: str]. DOC201: Method `Witnesses._create_operation` does not have a return section in docstring -- GitLab From 928f80bc2c65a22a1b9c5f170d197edcbdddf1da Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:36:21 +0200 Subject: [PATCH 05/21] Fix pydoclint errors in ui/screens/operations/hive_power_management/common_hive_power/additional_info_widgets.py.WithdrawalInfo --- .../common_hive_power/additional_info_widgets.py | 10 +++++++++- pydoclint-errors-baseline.txt | 6 ------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/clive/__private/ui/screens/operations/hive_power_management/common_hive_power/additional_info_widgets.py b/clive/__private/ui/screens/operations/hive_power_management/common_hive_power/additional_info_widgets.py index 3bca78a241..5aa443c161 100644 --- a/clive/__private/ui/screens/operations/hive_power_management/common_hive_power/additional_info_widgets.py +++ b/clive/__private/ui/screens/operations/hive_power_management/common_hive_power/additional_info_widgets.py @@ -24,7 +24,15 @@ if TYPE_CHECKING: class WithdrawalInfo(Vertical, CliveWidget): - """Widget that displays all withdrawal information.""" + """ + Widget that displays all withdrawal information. + + Attributes: + DEFAULT_CSS: Default CSS for the withdrawal info widget. + + Args: + provider: Data provider that provides the data for the widget. + """ DEFAULT_CSS = """ WithdrawalInfo { diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 5237f400e9..4ad296b514 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -410,12 +410,6 @@ clive/__private/ui/screens/operations/governance_operations/witness/witness.py DOC103: Method `Witnesses._create_operation`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [vote: bool, witness: str]. DOC201: Method `Witnesses._create_operation` does not have a return section in docstring -------------------- -clive/__private/ui/screens/operations/hive_power_management/common_hive_power/additional_info_widgets.py - DOC601: Class `WithdrawalInfo`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `WithdrawalInfo`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC101: Method `WithdrawalInfo.__init__`: Docstring contains fewer arguments than in function signature. - DOC103: Method `WithdrawalInfo.__init__`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [provider: HivePowerDataProvider]. --------------------- clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py DOC601: Class `DelegationsTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `DelegationsTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [ATTRIBUTE_TO_WATCH: , NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab From 67ee2049f1243dcc4e42d2b320fa3dbca281db8d Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:37:39 +0200 Subject: [PATCH 06/21] Fix pydoclint errors in ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py.DelegationsTable --- .../delegate_hive_power/delegate_hive_power.py | 8 +++++++- pydoclint-errors-baseline.txt | 2 -- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py b/clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py index de4629d571..0cf71f735e 100644 --- a/clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py +++ b/clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py @@ -70,7 +70,13 @@ class Delegation(CliveCheckerboardTableRow): class DelegationsTable(CliveCheckerboardTable): - """Table with delegations.""" + """ + Table with delegations. + + Attributes: + ATTRIBUTE_TO_WATCH: Attribute to watch for changes. + NO_CONTENT_TEXT: Text to display when there are no delegations. + """ ATTRIBUTE_TO_WATCH = "_content" NO_CONTENT_TEXT = "You have no delegations" diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 4ad296b514..e625ff9d64 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -411,8 +411,6 @@ clive/__private/ui/screens/operations/governance_operations/witness/witness.py DOC201: Method `Witnesses._create_operation` does not have a return section in docstring -------------------- clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py - DOC601: Class `DelegationsTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `DelegationsTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [ATTRIBUTE_TO_WATCH: , NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC601: Class `DelegateHivePower`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `DelegateHivePower`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -------------------- -- GitLab From b4a0bd63a213aeefd52596913caba150a7ea7fc5 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:38:09 +0200 Subject: [PATCH 07/21] Fix pydoclint errors in ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py.DelegateHivePower --- .../delegate_hive_power/delegate_hive_power.py | 7 ++++++- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py b/clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py index 0cf71f735e..1bf0e6ad08 100644 --- a/clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py +++ b/clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py @@ -108,7 +108,12 @@ class DelegationsTable(CliveCheckerboardTable): class DelegateHivePower(TabPane, OperationActionBindings): - """TabPane with all content about delegate hp.""" + """ + TabPane with all content about delegate hp. + + Attributes: + DEFAULT_CSS: Default CSS for tab pane. + """ DEFAULT_CSS = get_css_from_relative_path(__file__) diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index e625ff9d64..d5d0fd367a 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -410,10 +410,6 @@ clive/__private/ui/screens/operations/governance_operations/witness/witness.py DOC103: Method `Witnesses._create_operation`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [vote: bool, witness: str]. DOC201: Method `Witnesses._create_operation` does not have a return section in docstring -------------------- -clive/__private/ui/screens/operations/hive_power_management/delegate_hive_power/delegate_hive_power.py - DOC601: Class `DelegateHivePower`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `DelegateHivePower`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) --------------------- clive/__private/ui/screens/operations/hive_power_management/power_down/power_down.py DOC101: Method `WithdrawRoutesDisplay._update_withdraw_routes`: Docstring contains fewer arguments than in function signature. DOC103: Method `WithdrawRoutesDisplay._update_withdraw_routes`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [content: HivePowerData | NotUpdatedYet]. -- GitLab From c062faa461825f8c375465c2b724ae7f5bb4cded Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:40:15 +0200 Subject: [PATCH 08/21] Fix pydoclint errors in ui/screens/operations/hive_power_management/power_down/power_down.py.PowerDown --- .../hive_power_management/power_down/power_down.py | 7 ++++++- pydoclint-errors-baseline.txt | 2 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/clive/__private/ui/screens/operations/hive_power_management/power_down/power_down.py b/clive/__private/ui/screens/operations/hive_power_management/power_down/power_down.py index 93dc45ec39..90aed22a44 100644 --- a/clive/__private/ui/screens/operations/hive_power_management/power_down/power_down.py +++ b/clive/__private/ui/screens/operations/hive_power_management/power_down/power_down.py @@ -129,7 +129,12 @@ class PendingPowerDown(CliveCheckerboardTable): class PowerDown(TabPane, OperationActionBindings): - """TabPane with all content about power down.""" + """ + TabPane with all content about power down. + + Attributes: + DEFAULT_CSS: Default CSS for the tab pane. + """ DEFAULT_CSS = get_css_from_relative_path(__file__) diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index d5d0fd367a..e251d586ea 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -413,8 +413,6 @@ clive/__private/ui/screens/operations/governance_operations/witness/witness.py clive/__private/ui/screens/operations/hive_power_management/power_down/power_down.py DOC101: Method `WithdrawRoutesDisplay._update_withdraw_routes`: Docstring contains fewer arguments than in function signature. DOC103: Method `WithdrawRoutesDisplay._update_withdraw_routes`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [content: HivePowerData | NotUpdatedYet]. - DOC601: Class `PowerDown`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `PowerDown`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC201: Method `PowerDown._calculate_one_withdrawal` does not have a return section in docstring -------------------- clive/__private/ui/screens/operations/hive_power_management/power_up/power_up.py -- GitLab From 9401df27d43abdd05ad91fe0976d2711b91c9692 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:41:27 +0200 Subject: [PATCH 09/21] Fix pydoclint errors in ui/screens/operations/hive_power_management/power_up/power_up.py.PowerUp --- .../operations/hive_power_management/power_up/power_up.py | 7 ++++++- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/clive/__private/ui/screens/operations/hive_power_management/power_up/power_up.py b/clive/__private/ui/screens/operations/hive_power_management/power_up/power_up.py index 139cfd4b39..c7c37bf7f3 100644 --- a/clive/__private/ui/screens/operations/hive_power_management/power_up/power_up.py +++ b/clive/__private/ui/screens/operations/hive_power_management/power_up/power_up.py @@ -24,7 +24,12 @@ if TYPE_CHECKING: class PowerUp(TabPane, OperationActionBindings): - """TabPane with all content about power up.""" + """ + TabPane with all content about power up. + + Attributes: + DEFAULT_CSS: Default CSS for the power up screen. + """ DEFAULT_CSS = get_css_from_relative_path(__file__) diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index e251d586ea..3135722f84 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -415,10 +415,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow DOC103: Method `WithdrawRoutesDisplay._update_withdraw_routes`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [content: HivePowerData | NotUpdatedYet]. DOC201: Method `PowerDown._calculate_one_withdrawal` does not have a return section in docstring -------------------- -clive/__private/ui/screens/operations/hive_power_management/power_up/power_up.py - DOC601: Class `PowerUp`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `PowerUp`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) --------------------- clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py DOC601: Class `WithdrawRoutesTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `WithdrawRoutesTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [ATTRIBUTE_TO_WATCH: , NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab From 17ca94468133f3f4d1c534a13c906dafc4818a34 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:43:13 +0200 Subject: [PATCH 10/21] Fix pydoclint errors in ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py.WithdrawRoutesTable --- .../withdraw_routes/withdraw_routes.py | 8 +++++++- pydoclint-errors-baseline.txt | 2 -- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py b/clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py index 902e1a1a4d..e6e555aeb2 100644 --- a/clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py +++ b/clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py @@ -71,7 +71,13 @@ class WithdrawRoute(CliveCheckerboardTableRow): class WithdrawRoutesTable(CliveCheckerboardTable): - """Table with WithdrawRoutes.""" + """ + Table with WithdrawRoutes. + + Attributes: + ATTRIBUTE_TO_WATCH: Attribute to watch for updates. + NO_CONTENT_TEXT: Text to display when there are no withdraw routes. + """ ATTRIBUTE_TO_WATCH = "_content" NO_CONTENT_TEXT = "You have no withdraw routes" diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 3135722f84..b035a16468 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -416,8 +416,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow DOC201: Method `PowerDown._calculate_one_withdrawal` does not have a return section in docstring -------------------- clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py - DOC601: Class `WithdrawRoutesTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `WithdrawRoutesTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [ATTRIBUTE_TO_WATCH: , NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC601: Class `WithdrawRoutes`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `WithdrawRoutes`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_AUTO_VEST: Final[bool], DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -------------------- -- GitLab From 45f27d314803ac0bca35c49f0a9c6750f20d5e7c Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:43:38 +0200 Subject: [PATCH 11/21] Fix pydoclint errors in ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py.WithdrawRoutes --- .../withdraw_routes/withdraw_routes.py | 8 +++++++- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py b/clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py index e6e555aeb2..dd12969c2e 100644 --- a/clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py +++ b/clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py @@ -112,7 +112,13 @@ class WithdrawRoutesTable(CliveCheckerboardTable): class WithdrawRoutes(TabPane, OperationActionBindings): - """TabPane with all content about setting withdraw routes.""" + """ + TabPane with all content about setting withdraw routes. + + Attributes: + DEFAULT_CSS: Default CSS for the withdraw routes screen. + DEFAULT_AUTO_VEST: Default value for the auto vest checkbox. + """ DEFAULT_CSS = get_css_from_relative_path(__file__) DEFAULT_AUTO_VEST: Final[bool] = False diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index b035a16468..9704405414 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -415,10 +415,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow DOC103: Method `WithdrawRoutesDisplay._update_withdraw_routes`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [content: HivePowerData | NotUpdatedYet]. DOC201: Method `PowerDown._calculate_one_withdrawal` does not have a return section in docstring -------------------- -clive/__private/ui/screens/operations/hive_power_management/withdraw_routes/withdraw_routes.py - DOC601: Class `WithdrawRoutes`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `WithdrawRoutes`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_AUTO_VEST: Final[bool], DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) --------------------- clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- -- GitLab From bdc8b159f8c8906a149e8c1211a9182057594bf7 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:46:19 +0200 Subject: [PATCH 12/21] Fix pydoclint errors in ui/screens/settings/account_management/bad_accounts.py.BadAccountsTable --- .../settings/account_management/bad_accounts.py | 10 +++++++++- pydoclint-errors-baseline.txt | 2 -- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/clive/__private/ui/screens/settings/account_management/bad_accounts.py b/clive/__private/ui/screens/settings/account_management/bad_accounts.py index 0c4f896b8b..94894f5c3d 100644 --- a/clive/__private/ui/screens/settings/account_management/bad_accounts.py +++ b/clive/__private/ui/screens/settings/account_management/bad_accounts.py @@ -27,7 +27,15 @@ if TYPE_CHECKING: class BadAccountsTable(CliveCheckerboardTable): - """Table for a bad accounts.""" + """ + Table for a bad accounts. + + Attributes: + DEFAULT_CSS: Default CSS for the bad accounts table. + BINDINGS: Key bindings for navigating through pages. + MAX_ACCOUNTS_ON_PAGE: Maximum number of accounts displayed on one page. + FIRST_PAGE_INDEX: Index of the first page. + """ DEFAULT_CSS = """ BadAccountsTable { diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 9704405414..a57af63f55 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -419,8 +419,6 @@ clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- clive/__private/ui/screens/settings/account_management/bad_accounts.py - DOC601: Class `BadAccountsTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `BadAccountsTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [BINDINGS: , DEFAULT_CSS: , FIRST_PAGE_INDEX: Final[int], MAX_ACCOUNTS_ON_PAGE: Final[int]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC601: Class `BadAccounts`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `BadAccounts`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: , TITLE: Final[str]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -------------------- -- GitLab From 2338ae53c54e83381ae9ed12f69c91207a62c5be Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:47:04 +0200 Subject: [PATCH 13/21] Fix pydoclint errors in ui/screens/settings/account_management/bad_accounts.py.BadAccounts --- .../screens/settings/account_management/bad_accounts.py | 8 +++++++- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/clive/__private/ui/screens/settings/account_management/bad_accounts.py b/clive/__private/ui/screens/settings/account_management/bad_accounts.py index 94894f5c3d..35c5e87bf9 100644 --- a/clive/__private/ui/screens/settings/account_management/bad_accounts.py +++ b/clive/__private/ui/screens/settings/account_management/bad_accounts.py @@ -152,7 +152,13 @@ class BadAccountsTable(CliveCheckerboardTable): class BadAccounts(TabPane): - """Currently only used to display the list of bad accounts (cannot be modified).""" + """ + Currently only used to display the list of bad accounts (cannot be modified). + + Attributes: + DEFAULT_CSS: Default CSS for the BadAccounts screen. + TITLE: Title of the BadAccounts screen. + """ DEFAULT_CSS = """ BadAccounts { diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index a57af63f55..4a3be6d12b 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -418,10 +418,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- -clive/__private/ui/screens/settings/account_management/bad_accounts.py - DOC601: Class `BadAccounts`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `BadAccounts`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: , TITLE: Final[str]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) --------------------- clive/__private/ui/screens/settings/account_management/common/manage_accounts_tab_pane.py DOC601: Class `ManageAccountsTabPane`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `ManageAccountsTabPane`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab From f971814df38bc858ee0df16afb96325d6fa1e5db Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:48:12 +0200 Subject: [PATCH 14/21] Fix pydoclint errors in ui/screens/settings/account_management/common/manage_accounts_tab_pane.py.ManageAccountsTabPane --- .../common/manage_accounts_tab_pane.py | 11 ++++++++++- pydoclint-errors-baseline.txt | 6 ------ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/clive/__private/ui/screens/settings/account_management/common/manage_accounts_tab_pane.py b/clive/__private/ui/screens/settings/account_management/common/manage_accounts_tab_pane.py index 472a0cea41..60b85c6732 100644 --- a/clive/__private/ui/screens/settings/account_management/common/manage_accounts_tab_pane.py +++ b/clive/__private/ui/screens/settings/account_management/common/manage_accounts_tab_pane.py @@ -23,7 +23,16 @@ if TYPE_CHECKING: class ManageAccountsTabPane(TabPane, CliveWidget): - """TabPane used to add and delete watched or known accounts.""" + """ + TabPane used to add and delete watched or known accounts. + + Attributes: + DEFAULT_CSS: Default CSS for the manage accounts tab pane. + + Args: + title: Title of the tab pane. + accounts_type: Type of accounts to manage. + """ DEFAULT_CSS = get_css_from_relative_path(__file__) diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 4a3be6d12b..067ab20e9e 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -418,12 +418,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- -clive/__private/ui/screens/settings/account_management/common/manage_accounts_tab_pane.py - DOC601: Class `ManageAccountsTabPane`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `ManageAccountsTabPane`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC101: Method `ManageAccountsTabPane.__init__`: Docstring contains fewer arguments than in function signature. - DOC103: Method `ManageAccountsTabPane.__init__`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [accounts_type: AccountsType, title: str]. --------------------- clive/__private/ui/screens/settings/account_management/common/manage_accounts_table.py DOC601: Class `ManageAccountsTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `ManageAccountsTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [ATTRIBUTE_TO_WATCH: , DEFAULT_CSS: , NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab From d25234643297afaa67da0580111ead36e21103e5 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:49:14 +0200 Subject: [PATCH 15/21] Fix pydoclint errors in ui/screens/settings/account_management/common/manage_accounts_table.py.ManageAccountsTable --- .../common/manage_accounts_table.py | 12 +++++++++++- pydoclint-errors-baseline.txt | 6 ------ 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/clive/__private/ui/screens/settings/account_management/common/manage_accounts_table.py b/clive/__private/ui/screens/settings/account_management/common/manage_accounts_table.py index 9c8d4afa51..d24d03f076 100644 --- a/clive/__private/ui/screens/settings/account_management/common/manage_accounts_table.py +++ b/clive/__private/ui/screens/settings/account_management/common/manage_accounts_table.py @@ -62,7 +62,17 @@ class AccountRow(CliveCheckerboardTableRow): class ManageAccountsTable(CliveCheckerboardTable): - """Common table for a known and watched accounts.""" + """ + Common table for a known and watched accounts. + + Attributes: + DEFAULT_CSS: Default CSS for the manage accounts table. + ATTRIBUTE_TO_WATCH: Attribute to watch for updates. + NO_CONTENT_TEXT: Text to display when there are no accounts. + + Args: + accounts_type: Type of accounts to manage. + """ DEFAULT_CSS = """ ManageAccountsTable { diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 067ab20e9e..ce0ab8a77e 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -418,12 +418,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- -clive/__private/ui/screens/settings/account_management/common/manage_accounts_table.py - DOC601: Class `ManageAccountsTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `ManageAccountsTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [ATTRIBUTE_TO_WATCH: , DEFAULT_CSS: , NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC101: Method `ManageAccountsTable.__init__`: Docstring contains fewer arguments than in function signature. - DOC103: Method `ManageAccountsTable.__init__`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [accounts_type: AccountsType]. --------------------- clive/__private/ui/screens/settings/account_management/known_accounts.py DOC601: Class `KnownAccounts`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `KnownAccounts`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [TITLE: Final[str]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab From c6e7e2c3b5c1cbb2394bdf17cc110c9b69d208f7 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:50:06 +0200 Subject: [PATCH 16/21] Fix pydoclint errors in ui/screens/settings/account_management/known_accounts.py.KnownAccounts --- .../screens/settings/account_management/known_accounts.py | 7 ++++++- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/clive/__private/ui/screens/settings/account_management/known_accounts.py b/clive/__private/ui/screens/settings/account_management/known_accounts.py index 390a44b7a4..85bd9c96fc 100644 --- a/clive/__private/ui/screens/settings/account_management/known_accounts.py +++ b/clive/__private/ui/screens/settings/account_management/known_accounts.py @@ -6,7 +6,12 @@ from clive.__private.ui.screens.settings.account_management.common.manage_accoun class KnownAccounts(ManageAccountsTabPane): - """TabPane used to add and delete known accounts.""" + """ + TabPane used to add and delete known accounts. + + Attributes: + TITLE: Title of the tab pane. + """ TITLE: Final[str] = "Known accounts" diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index ce0ab8a77e..37c1f4f26e 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -418,10 +418,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- -clive/__private/ui/screens/settings/account_management/known_accounts.py - DOC601: Class `KnownAccounts`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `KnownAccounts`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [TITLE: Final[str]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) --------------------- clive/__private/ui/screens/settings/account_management/tracked_accounts.py DOC601: Class `TrackedAccounts`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `TrackedAccounts`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: , TITLE: Final[str]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab From 29e2f5cc8f13c6da419ff971d29ede6112b5bf63 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:51:25 +0200 Subject: [PATCH 17/21] Fix pydoclint errors in ui/screens/settings/account_management/tracked_accounts.py.TrackedAccounts --- .../settings/account_management/tracked_accounts.py | 8 +++++++- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/clive/__private/ui/screens/settings/account_management/tracked_accounts.py b/clive/__private/ui/screens/settings/account_management/tracked_accounts.py index 415320272d..30af3112ba 100644 --- a/clive/__private/ui/screens/settings/account_management/tracked_accounts.py +++ b/clive/__private/ui/screens/settings/account_management/tracked_accounts.py @@ -6,7 +6,13 @@ from clive.__private.ui.screens.settings.account_management.common.manage_accoun class TrackedAccounts(ManageAccountsTabPane): - """TabPane used to add and delete tracked accounts.""" + """ + TabPane used to add and delete tracked accounts. + + Attributes: + DEFAULT_CSS: Default CSS for the tracked accounts tab pane. + TITLE: Title of the tab pane. + """ DEFAULT_CSS = """ TrackedAccounts { diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 37c1f4f26e..4dda3602bd 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -418,10 +418,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- -clive/__private/ui/screens/settings/account_management/tracked_accounts.py - DOC601: Class `TrackedAccounts`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `TrackedAccounts`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [DEFAULT_CSS: , TITLE: Final[str]]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) --------------------- clive/__private/ui/screens/settings/manage_key_aliases/manage_key_aliases.py DOC601: Class `ManageKeyAliasesTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `ManageKeyAliasesTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [ATTRIBUTE_TO_WATCH: , NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab From db1d856a5a04d548caf5cb44cae7316daa077b00 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:53:15 +0200 Subject: [PATCH 18/21] Fix pydoclint errors in ui/screens/settings/manage_key_aliases/manage_key_aliases.py.ManageKeyAliasesTable --- .../settings/manage_key_aliases/manage_key_aliases.py | 8 +++++++- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/clive/__private/ui/screens/settings/manage_key_aliases/manage_key_aliases.py b/clive/__private/ui/screens/settings/manage_key_aliases/manage_key_aliases.py index 33be3d1d8c..85424f7a2f 100644 --- a/clive/__private/ui/screens/settings/manage_key_aliases/manage_key_aliases.py +++ b/clive/__private/ui/screens/settings/manage_key_aliases/manage_key_aliases.py @@ -130,7 +130,13 @@ class KeyAliasesHeader(Horizontal): class ManageKeyAliasesTable(CliveCheckerboardTable): - """Table with KeyAliases.""" + """ + Table with KeyAliases. + + Attributes: + ATTRIBUTE_TO_WATCH: Attribute to watch for updates. + NO_CONTENT_TEXT: Text to display when there are no key aliases. + """ ATTRIBUTE_TO_WATCH = "profile_reactive" NO_CONTENT_TEXT = "You have no key aliases" diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 4dda3602bd..352f010bc0 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -418,10 +418,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- -clive/__private/ui/screens/settings/manage_key_aliases/manage_key_aliases.py - DOC601: Class `ManageKeyAliasesTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `ManageKeyAliasesTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [ATTRIBUTE_TO_WATCH: , NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) --------------------- clive/__private/ui/screens/transaction_summary/cart_table.py DOC101: Method `MoveUpButton.__init__`: Docstring contains fewer arguments than in function signature. DOC103: Method `MoveUpButton.__init__`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [disabled: bool]. -- GitLab From 7d743ffe753b19bec3fa2f4350f620f0a050ecd4 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:55:05 +0200 Subject: [PATCH 19/21] Fix pydoclint errors in ui/screens/transaction_summary/cart_table.py.MoveDownButton --- .../ui/screens/transaction_summary/cart_table.py | 14 ++++++++++++-- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/clive/__private/ui/screens/transaction_summary/cart_table.py b/clive/__private/ui/screens/transaction_summary/cart_table.py index cdd335ea6f..c818963de9 100644 --- a/clive/__private/ui/screens/transaction_summary/cart_table.py +++ b/clive/__private/ui/screens/transaction_summary/cart_table.py @@ -35,14 +35,24 @@ if TYPE_CHECKING: class MoveUpButton(CliveButton): - """Button used for moving the operation up in the cart.""" + """ + Button used for moving the operation up in the cart. + + Args: + disabled: Whether the button should be disabled initially. + """ def __init__(self, *, disabled: bool = False) -> None: super().__init__("↑", id_="move-up-button", disabled=disabled) class MoveDownButton(CliveButton): - """Button used for moving the operation down in the cart.""" + """ + Button used for moving the operation down in the cart. + + Args: + disabled: Whether the button should be disabled initially. + """ def __init__(self, *, disabled: bool = False) -> None: super().__init__("↓", id_="move-down-button", disabled=disabled) diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 352f010bc0..965b466235 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -419,10 +419,6 @@ clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- clive/__private/ui/screens/transaction_summary/cart_table.py - DOC101: Method `MoveUpButton.__init__`: Docstring contains fewer arguments than in function signature. - DOC103: Method `MoveUpButton.__init__`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [disabled: bool]. - DOC101: Method `MoveDownButton.__init__`: Docstring contains fewer arguments than in function signature. - DOC103: Method `MoveDownButton.__init__`: Docstring arguments are different from function arguments. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Arguments in the function signature but not in the docstring: [disabled: bool]. DOC601: Class `CartTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `CartTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC601: Class `Modified`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab From 0289497b3fe568d5d6a2d8697eafd2b6949b9660 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:57:48 +0200 Subject: [PATCH 20/21] Fix pydoclint errors in ui/screens/transaction_summary/cart_table.py.CartTable --- .../__private/ui/screens/transaction_summary/cart_table.py | 7 ++++++- pydoclint-errors-baseline.txt | 2 -- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/clive/__private/ui/screens/transaction_summary/cart_table.py b/clive/__private/ui/screens/transaction_summary/cart_table.py index c818963de9..9efb387a47 100644 --- a/clive/__private/ui/screens/transaction_summary/cart_table.py +++ b/clive/__private/ui/screens/transaction_summary/cart_table.py @@ -267,7 +267,12 @@ class CartHeader(Horizontal): class CartTable(CliveCheckerboardTable): - """Table with CartItems.""" + """ + Table with CartItems. + + Attributes: + NO_CONTENT_TEXT: Text displayed when there are no items in the cart. + """ NO_CONTENT_TEXT = "Cart is empty" diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 965b466235..02cfd1f8c2 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -419,8 +419,6 @@ clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- clive/__private/ui/screens/transaction_summary/cart_table.py - DOC601: Class `CartTable`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `CartTable`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [NO_CONTENT_TEXT: ]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC601: Class `Modified`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `Modified`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [transaction: Transaction]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -------------------- -- GitLab From c2628dddafc0fac13e2001002b6eb224144257a7 Mon Sep 17 00:00:00 2001 From: Dawid Nocinski Date: Sun, 20 Jul 2025 16:58:25 +0200 Subject: [PATCH 21/21] Fix pydoclint errors in ui/screens/transaction_summary/cart_table.py.Modified --- .../__private/ui/screens/transaction_summary/cart_table.py | 7 ++++++- pydoclint-errors-baseline.txt | 4 ---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/clive/__private/ui/screens/transaction_summary/cart_table.py b/clive/__private/ui/screens/transaction_summary/cart_table.py index 9efb387a47..ddc1abb677 100644 --- a/clive/__private/ui/screens/transaction_summary/cart_table.py +++ b/clive/__private/ui/screens/transaction_summary/cart_table.py @@ -278,7 +278,12 @@ class CartTable(CliveCheckerboardTable): @dataclass class Modified(Message): - """Message sent when operations in CartTable were reordered or removed.""" + """ + Message sent when operations in cart table were reordered or removed. + + Attributes: + transaction: The modified transaction after the operations were reordered or removed. + """ transaction: Transaction diff --git a/pydoclint-errors-baseline.txt b/pydoclint-errors-baseline.txt index 02cfd1f8c2..8ff13b160e 100644 --- a/pydoclint-errors-baseline.txt +++ b/pydoclint-errors-baseline.txt @@ -418,10 +418,6 @@ clive/__private/ui/screens/operations/hive_power_management/power_down/power_dow clive/__private/ui/screens/operations/transfer_to_account/transfer_to_account.py DOC201: Method `TransferToAccount._check_is_known_exchange_in_input` does not have a return section in docstring -------------------- -clive/__private/ui/screens/transaction_summary/cart_table.py - DOC601: Class `Modified`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) - DOC603: Class `Modified`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [transaction: Transaction]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) --------------------- clive/__private/ui/screens/transaction_summary/transaction_metadata_container.py DOC601: Class `TaposHolder`: Class docstring contains fewer class attributes than actual class attributes. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) DOC603: Class `TaposHolder`: Class docstring attributes are different from actual class attributes. (Or could be other formatting issues: https://jsh9.github.io/pydoclint/violation_codes.html#notes-on-doc103 ). Attributes in the class definition but not in the docstring: [transaction: Transaction]. (Please read https://jsh9.github.io/pydoclint/checking_class_attributes.html on how to correctly document class attributes.) -- GitLab