Follow-up from "Draft: Cli command clive process account-creation simplified"

The following discussions from !774 (merged) should be addressed:

  • @mzebrak started a discussion: (+4 comments)

    maybe we can wrap similar as extract_params - but this time with *extract_args(locals())?

  • @mzebrak started a discussion:

    It does nothing there so can be removed

  • @mzebrak started a discussion: (+3 comments)

    can you reorder methods there? Like properties, public methods used for setting up the command,validate, fetch_data, run, post run, internals?

  • @mzebrak started a discussion: (+1 comment)

    Not sure if this is necessary because looks like these this check is being done earlier now:

    image

    and

    image

    So looks like its not possible to get this error now? But maybe better to keep it, since if set_keys or set_memo_key was missing, this would be raised?

  • @mzebrak started a discussion: (+3 comments)

    See origin/mzebrak/msobczyk/cli-account-creation-simplified - these can accept just the name. no need to initialize option

    And should be named adequately as param decls in option or given string

  • @mzebrak started a discussion: (+1 comment)

    See origin/mzebrak/msobczyk/cli-account-creation-simplified - looks like no need to have a separate set_memo_key. pass it in set_keys

  • @mzebrak started a discussion:

    Maybe can refer to defaults in constants but this would require approach like make_process_account_creation and settings __doc__ of this function dynamically

  • @mzebrak started a discussion:

    ft !774 (comment 230472)

    looks like we should add some util that will add this at the end of text help

Edited by Mateusz Żebrak