hive issueshttps://gitlab.syncad.com/groups/hive/-/issues2024-03-26T11:11:43Zhttps://gitlab.syncad.com/hive/test-tools/-/issues/46Wallet re implementation with beekeeper- missing functions.2024-03-26T11:11:43ZRadosław MasłowskiWallet re implementation with beekeeper- missing functions.In this place I store missing functions, which use to be implement.
1. Missing custom json operation for delegate_rc in schemas
2. ~~Problem with broadcasting some operations nonblocking~~
3. Storing logs from tests in tmp folders, inst...In this place I store missing functions, which use to be implement.
1. Missing custom json operation for delegate_rc in schemas
2. ~~Problem with broadcasting some operations nonblocking~~
3. Storing logs from tests in tmp folders, instead of folder with tests.Krzysztof Mochockikmochocki@syncad.comKrzysztof Mochockikmochocki@syncad.comhttps://gitlab.syncad.com/hive/clive/-/issues/167improve cli testing framework by refactoring checkers module2024-03-20T10:06:32ZMarcin Sobczykimprove cli testing framework by refactoring checkers modulecheckers is separate module but it could be part of TestingCli class, we should also consider if we always run cli command (most likely "clive show ...") or just provide invocation result of type click.testing.Resultcheckers is separate module but it could be part of TestingCli class, we should also consider if we always run cli command (most likely "clive show ...") or just provide invocation result of type click.testing.Resulthttps://gitlab.syncad.com/hive/denser/-/issues/283Cannot login via Keychain in non-strict mode using account authority2024-03-19T16:14:50ZWojciech BarcikCannot login via Keychain in non-strict mode using account authorityTo duplicate the issue:
1. Add account `guest4test` with private key to Keychain.
2. Add account `guest4test7` to Keychain and point its posting account authority to guest4test.
3. Try to login at http://localhost:5000/signin. This fail...To duplicate the issue:
1. Add account `guest4test` with private key to Keychain.
2. Add account `guest4test7` to Keychain and point its posting account authority to guest4test.
3. Try to login at http://localhost:5000/signin. This fails with error "WaxChainApiError: Error sending request to the Hive API: "{"code":-32003,"message":"missing required posting authority"
Not sure whether it's Keychain issue or something in our code.Wojciech BarcikWojciech Barcikhttps://gitlab.syncad.com/hive/hive/-/issues/670[testnet] Primary accounts hive.fund and steem.dao doesn't have authority2024-03-21T15:42:11ZMichał Kudelakudmich@syncad.com[testnet] Primary accounts hive.fund and steem.dao doesn't have authority@ABW If you try to send a transaction using one of accounts `hive.fund` or `steem.dao` before activate hardforks. You will encounter an error:
```python
unknown key: hive.fund of type: std::__cxx11::basic_string<char, std::char_traits<c...@ABW If you try to send a transaction using one of accounts `hive.fund` or `steem.dao` before activate hardforks. You will encounter an error:
```python
unknown key: hive.fund of type: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > at multiindex lookup: hive::chain::account_authority_object.index<hive::chain::by_account>
{"kt":"std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >","multiindex":"hive::chain::account_authority_object","indexed_by_typename":"hive::chain::by_account","key":"hive.fund"}
unknown key: hive.fund of type: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > at multiindex lookup: hive::chain::account_authority_object.index<hive::chain::by_account>
{"kt":"std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >","multiindex":"hive::chain::account_authority_object","indexed_by_typename":"hive::chain::by_account","key":"hive.fund"}
chainbase.hpp:1179 get: (unformatted args: ("sigs",[]))
{"sigs":[],"what":"0 exception: unspecified\nunknown key: hive.fund of type: std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > at multiindex lookup: hive::chain::account_authority_object.index<hive::chain::by_account>\n {\"kt\":\"std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >\",\"multiindex\":\"hive::chain::account_authority_object\",\"indexed_by_typename\":\"hive::chain::by_account\",\"key\":\"hive.fund\"}\n chainbase.hpp:1179 get"}
```
related to a `colony` plugin: https://gitlab.syncad.com/hive/hive/-/merge_requests/1224Andrzej LisakAndrzej Lisakhttps://gitlab.syncad.com/hive/hive-account-creator/-/issues/1Change req.body.account to be always lower case2024-03-18T23:31:08ZDamian JanusChange req.body.account to be always lower caseDamian JanusDamian Janushttps://gitlab.syncad.com/hive/block_explorer_ui/-/issues/229Changing Explorer backend to a non-functional one doesn't allow further changes2024-03-19T15:04:59ZDan NotesteinChanging Explorer backend to a non-functional one doesn't allow further changeshttps://gitlab.syncad.com/hive/haf_block_explorer/-/issues/73Procedure building images for testing and release purposes should be thersame2024-03-25T14:22:45ZBartek WronaProcedure building images for testing and release purposes should be thersameEven we want to build official image just before push on demand in both cases build should be done the same way. Right now haf_block_explorer and balance_tracker uses different scripts and jobs to do it, what due to bug in:
https://gitla...Even we want to build official image just before push on demand in both cases build should be done the same way. Right now haf_block_explorer and balance_tracker uses different scripts and jobs to do it, what due to bug in:
https://gitlab.syncad.com/hive/common-ci-configuration/-/blob/develop/templates/docker_image_jobs.gitlab-ci.yml?ref_type=heads#L44
which hidden important part of before_script inherited from:
https://gitlab.syncad.com/hive/common-ci-configuration/-/blob/develop/templates/docker_image_jobs.gitlab-ci.yml?ref_type=heads#L9
lead to image build failure.
All or most of code required to build the image should be stored in local scripts, to allow easy local reproducing of potential problems and make code much more readable.
If our image builder needs to be preconfigured somehow, we should extend base image for that (which should be used in all cases) instead of "patching" code by missing statements put into before_script handlers what is hard to maintain and understand.Konrad BotorKonrad Botorhttps://gitlab.syncad.com/hive/haf/-/issues/217HAF Indexing fails after replaying with a 1.27.4 block_log2024-03-27T21:35:04ZDeathwinghi@deathwing.meHAF Indexing fails after replaying with a 1.27.4 block_log![image.png](/uploads/4bb701fbb92202e26c8bfc110199a2c5/image.png)
I have had this issue in two nodes now. What happens is that, despite the replay finishing without an issue, these errors pop up on indexing stage and destroy the overall...![image.png](/uploads/4bb701fbb92202e26c8bfc110199a2c5/image.png)
I have had this issue in two nodes now. What happens is that, despite the replay finishing without an issue, these errors pop up on indexing stage and destroy the overall state. No matter how many times its replayed, it does not fix it. A live sync (by deleting the block_log, which is the only file exists anyways) works fine.https://gitlab.syncad.com/hive/hive/-/issues/669HF28 test seems a lititle unstable2024-03-21T14:12:19ZDan NotesteinHF28 test seems a lititle unstableFailed once, but passed when the test was re-run here: https://gitlab.syncad.com/hive/haf/-/pipelines/89724.
If I recall correctly, the fail was due to something being late by one block.Failed once, but passed when the test was re-run here: https://gitlab.syncad.com/hive/haf/-/pipelines/89724.
If I recall correctly, the fail was due to something being late by one block.Krzysztof LeśniakKrzysztof Leśniakhttps://gitlab.syncad.com/hive/haf/-/issues/216We need tests for get_metadata2024-03-27T06:32:15ZMichal ZanderWe need tests for get_metadataIt seems that "get_metadata" function works incorrectly before HF21It seems that "get_metadata" function works incorrectly before HF21Mariusz TrelaMariusz Trelahttps://gitlab.syncad.com/hive/clive/-/issues/166Improve testing cli framework with features from python 3.122024-03-15T12:33:15ZMarcin SobczykImprove testing cli framework with features from python 3.12There are helper methods of TestingCli like process_savings_deposit or process_savings_withdrawal that are silimar to cli commands "clive process savings deposit", "clive process savings withdrawal" etc). We accept multiple named argumen...There are helper methods of TestingCli like process_savings_deposit or process_savings_withdrawal that are silimar to cli commands "clive process savings deposit", "clive process savings withdrawal" etc). We accept multiple named arguments. This is however not easily extansible (if there are more commands there will be more boilerplate code). In python however 3.12 there is implemented https://peps.python.org/pep-0692/ . This allows adding types to **kwargs argument, as in example:
```
class Movie(TypedDict):
title: str
year: NotRequired[int]
def foo(name, /, **kwargs: Unpack[Movie]) -> None: ...
```
we could define following types for kwargs:
```
class OperationCommon(TypedDict):
profile_name: NotRequired[str]
password: NotRequired[str]
sign: NotRequired[str]
beekeeper_remote: NotRequired[str]
broadcast: NotRequired[bool]
save_file: NotRequired[str]
class TransferCommon(TypedDict):
amount: Required[tt.Asset.AntT]
memo: NotRequired[bool]
from_account: NotRequired[str]
class Transfer(OperationCommon, TransferCommon):
to: Required[str]
```
and define method transfer inside class TestingCli:
```
def transfer(name, /, **kwargs: Unpack[Transfer]) -> Result: ...
```
Benefit is much shorter code, we can also reuse common options as in CliveTyper (where it is done by decorators, we could also use decorators here but this feature from python 3.12 is much simpler) and it will be easy to add more cli commands.
I'm not sure when we will use python 3.12, this will happen when we use ubuntu 24.04 for hive image (python 3.12 is default on ubuntu 24.04)https://gitlab.syncad.com/hive/wax/-/issues/23Prepare set of benchmark tests to verify WASM layer performance2024-03-14T16:46:11ZBartek WronaPrepare set of benchmark tests to verify WASM layer performanceWe need to intensively use functions exposed by Wax-wasm layer and gather their execution times. This set of tests will be needed to safely try to tweak emscripten builds and make WASM binaries smaller.
We don't need any advanced benchma...We need to intensively use functions exposed by Wax-wasm layer and gather their execution times. This set of tests will be needed to safely try to tweak emscripten builds and make WASM binaries smaller.
We don't need any advanced benchmark framework - just set of prepared function calls and accurate time measurementhttps://gitlab.syncad.com/hive/wax/-/issues/22Verify each Wasm exposed function is covered by playwright tests2024-03-14T15:55:41ZBartek WronaVerify each Wasm exposed function is covered by playwright testsProbably should wait for https://gitlab.syncad.com/hive/wax/-/issues/21Probably should wait for https://gitlab.syncad.com/hive/wax/-/issues/21Fabian WaszkiewiczFabian Waszkiewiczhttps://gitlab.syncad.com/hive/wax/-/issues/21Review list of exposed core C++ functions in wax and follow it in Wasm repres...2024-03-14T15:55:42ZBartek WronaReview list of exposed core C++ functions in wax and follow it in Wasm representationFabian WaszkiewiczFabian Waszkiewiczhttps://gitlab.syncad.com/hive/wax/-/issues/20Cover in regression testing usage of new TransactionBuilder properties/featur...2024-03-26T13:25:59ZBartek WronaCover in regression testing usage of new TransactionBuilder properties/features specific to transaction legacy serialization- [ ] legacy_id
- [ ] legacy_sigDigest
- [ ] legacy_signatureKeys
- [ ] toLegacyApi
are completely not tested in playwright test suite- [ ] legacy_id
- [ ] legacy_sigDigest
- [ ] legacy_signatureKeys
- [ ] toLegacyApi
are completely not tested in playwright test suiteFabian WaszkiewiczFabian Waszkiewiczhttps://gitlab.syncad.com/hive/vessel/-/issues/39Recurring transfers2024-03-14T09:06:15ZBartłomiej GórnickiRecurring transfersAs a user I would like to manage recurring transfers.As a user I would like to manage recurring transfers.https://gitlab.syncad.com/hive/vessel/-/issues/38Add Ledger support2024-03-14T09:05:19ZBartłomiej GórnickiAdd Ledger supportI would like to use vessel with my Ledger device storing my keys.
- Typescript library to communicate with Hive Ledger application: https://gitlab.com/engrave/ledger/ledger-app-hive
- Example implementation of CLI tool: https://gitlab.c...I would like to use vessel with my Ledger device storing my keys.
- Typescript library to communicate with Hive Ledger application: https://gitlab.com/engrave/ledger/ledger-app-hive
- Example implementation of CLI tool: https://gitlab.com/engrave/ledger/hive-ledger-cli
- Implementation of hiveledger.io: https://gitlab.com/engrave/ledger/hiveledgerhttps://gitlab.syncad.com/hive/vessel/-/issues/37Proxy account does not prevent voting on witnesses2024-03-14T08:50:11ZBartłomiej GórnickiProxy account does not prevent voting on witnessesIf the account has an active proxy set, I expect the "Witness voting" tab to prevent broadcasting useless transactions. The form should be modified to indicate it's not possible to vote in such a case.
Proxy:
![Screenshot_from_2024-03-1...If the account has an active proxy set, I expect the "Witness voting" tab to prevent broadcasting useless transactions. The form should be modified to indicate it's not possible to vote in such a case.
Proxy:
![Screenshot_from_2024-03-14_09-39-13](/uploads/35ddf6bff0a3f7ba7e3cd8963b7084ce/Screenshot_from_2024-03-14_09-39-13.png)
Witness voting:
![Screenshot_from_2024-03-14_09-39-35](/uploads/de5b7ea56277670af41285e0588e3faa/Screenshot_from_2024-03-14_09-39-35.png)https://gitlab.syncad.com/hive/vessel/-/issues/36Account name is not validated in "Send funds" form2024-03-14T00:01:36ZBartłomiej GórnickiAccount name is not validated in "Send funds" formAccount names should be validated an maybe there should a be warning to prevent sending funds to known scam accounts.
![Screenshot_from_2024-03-14_01-00-40](/uploads/0c884a2b0c2e08dff99733d67a655e21/Screenshot_from_2024-03-14_01-00-40.png)Account names should be validated an maybe there should a be warning to prevent sending funds to known scam accounts.
![Screenshot_from_2024-03-14_01-00-40](/uploads/0c884a2b0c2e08dff99733d67a655e21/Screenshot_from_2024-03-14_01-00-40.png)https://gitlab.syncad.com/hive/hive-renderer/-/issues/18isLinkSafeFn should be used during link sanitization2024-03-13T23:59:15ZBartłomiej GórnickiisLinkSafeFn should be used during link sanitization